On Mon, 29 Apr 2019 at 18:32, Andreas Gruenbacher <agruenba@xxxxxxxxxx> wrote: > From: Christoph Hellwig <hch@xxxxxx> > > Move the call to __generic_write_end into iomap_write_end instead of > duplicating it in each of the three branches. This requires open coding > the generic_write_end for the buffer_head case. Wouldn't it make sense to turn __generic_write_end into a void function? Right now, it just oddly return its copied argument. Andreas