On Mon 29-04-19 07:37:08, Shakeel Butt wrote: > On Mon, Apr 29, 2019 at 5:22 AM Michal Hocko <mhocko@xxxxxxxxxx> wrote: > > > > On Sun 28-04-19 16:56:13, Shakeel Butt wrote: > > > The documentation of __GFP_RETRY_MAYFAIL clearly mentioned that the > > > OOM killer will not be triggered and indeed the page alloc does not > > > invoke OOM killer for such allocations. However we do trigger memcg > > > OOM killer for __GFP_RETRY_MAYFAIL. Fix that. > > > > An example of __GFP_RETRY_MAYFAIL memcg OOM report would be nice. I > > thought we haven't been using that flag for memcg allocations yet. > > But this is definitely good to have addressed. > > Actually I am planning to use it for memcg allocations (specifically > fsnotify allocations). OK, then articulate it in the changelog please. > > > Signed-off-by: Shakeel Butt <shakeelb@xxxxxxxxxx> > > > > Acked-by: Michal Hocko <mhocko@xxxxxxxx> -- Michal Hocko SUSE Labs