Hi Kosaki, On Wed 20-04-11 09:33:26, KOSAKI Motohiro wrote: > > While I am in the cleanup mode. We should use VM_GROWSUP rather than > > tricky CONFIG_STACK_GROWSUP||CONFIG_IA64. > > > > What do you think? > > Now, VM_GROWSUP share the same value with VM_NOHUGEPAGE. > (this trick use the fact that thp don't support any stack growup architecture) I am not sure I understand you. AFAICS, VM_GROWSUP is defined to non 0 only if CONFIG_STACK_GROWSUP||CONFIG_IA64 (include/linux/mm.h). And we use it to determine whether expand_stack_growsup[*] should be defined (in include/linux/mm.h). The patch basically unifies the way how we export expand_stack_growsup function and how define it (in mm/mmap.c). So either we should use CONFIG_STACK_GROWSUP||CONFIG_IA64 at both places or we should use VM_GROWSUP trick. I am for the later one. Am I missing something? --- [*] the previous patch renamed expand_growsup to expand_stack_growsup. -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>