Re: [RFC PATCH 1/5] numa: introduce per-cgroup numa balancing locality, statistic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Subject: Re: [RFC PATCH 1/5] numa: introduce per-cgroup numa balancing locality, statistic
From: 王贇 <yun.wang@xxxxxxxxxxxxxxxxx>
Date: Tue, 23 Apr 2019 17:33:25 +0800
Cc: hannes@xxxxxxxxxxx, mhocko@xxxxxxxxxx, vdavydov.dev@xxxxxxxxx, Ingo Molnar <mingo@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx
In-reply-to: <20190423084722.GD11158@hirez.programming.kicks-ass.net>
References: <209d247e-c1b2-3235-2722-dd7c1f896483@linux.alibaba.com> <c0ec8861-2387-e73b-e450-2d636557a3dd@linux.alibaba.com> <20190423084722.GD11158@hirez.programming.kicks-ass.net>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Thunderbird/60.6.1


On 2019/4/23 下午4:47, Peter Zijlstra wrote:
> On Mon, Apr 22, 2019 at 10:11:24AM +0800, 王贇 wrote:
>> +	p->numa_faults_locality[mem_node == numa_node_id() ? 4 : 3] += pages;
> 
> Possibly: 3 + !!(mem_node = numa_node_id()), generates better code.

Sounds good~ will apply in next version.

Regards,
Michael Wang

>

Follow-Ups:
- Re: [RFC PATCH 1/5] numa: introduce per-cgroup numa balancing locality, statistic
  - From: Peter Zijlstra

References:
- [RFC PATCH 0/5] NUMA Balancer Suite
  - From: 王贇
- [RFC PATCH 1/5] numa: introduce per-cgroup numa balancing locality, statistic
  - From: 王贇
- Re: [RFC PATCH 1/5] numa: introduce per-cgroup numa balancing locality, statistic
  - From: Peter Zijlstra

Prev by Date: Re: [RFC PATCH 1/5] numa: introduce per-cgroup numa balancing locality, statistic
Next by Date: Re: [RFC PATCH 2/5] numa: append per-node execution info in memory.numa_stat
Previous by thread: Re: [RFC PATCH 1/5] numa: introduce per-cgroup numa balancing locality, statistic
Next by thread: Re: [RFC PATCH 1/5] numa: introduce per-cgroup numa balancing locality, statistic
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]