On Fri, 2011-04-01 at 20:05 +0530, Srikar Dronamraju wrote:
> + probept = uprobes_get_bkpt_addr(regs);
> + down_read(&mm->mmap_sem);
> + for (vma = mm->mmap; vma; vma = vma->vm_next) {
> + if (!valid_vma(vma))
> + continue;
> + if (probept < vma->vm_start || probept > vma->vm_end)
> + continue;
> + u = find_uprobe(vma->vm_file->f_mapping->host,
> + probept - vma->vm_start);
> + break;
> + }
Why the linear vma walk? Surely the find_vma() suffices since there can
only be one vma that matches a particular vaddr.
> + up_read(&mm->mmap_sem);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href