Re: [PATCH V4 00/10] memcg: per cgroup background reclaim

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On Mon, Apr 18, 2011 at 7:48 PM, Zhu Yanhai <zhu.yanhai@xxxxxxxxx> wrote:
Hi,

2011/4/19 Ying Han <yinghan@xxxxxxxxxx>:
>
> that is true.  I adopt the initial comment from Mel where we keep the same
> logic of triggering and stopping kswapd with low/high_wmarks and also
> comparing the usage_in_bytes to the wmarks. Either way is confusing and
> guess we just need to document it well.

IMO another thing need to document well is that a user must setup
high_wmark_distance before setup low_wmark_distance to to make it
start work, and zero  low_wmark_distance before zero
high_wmark_distance to stop it. Otherwise it won't pass the sanity
check, which is not quite obvious.

yes. will add into the document.

--Ying 

Thanks,
Zhu Yanhai

> --Ying
>>
>> --
>> Michal Hocko
>> SUSE Labs
>> SUSE LINUX s.r.o.
>> Lihovarska 1060/12
>> 190 00 Praha 9
>> Czech Republic
>
>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]