On Tue, Apr 9, 2019 at 9:25 PM Chris Down <chris@xxxxxxxxxxxxxx> wrote: > > Hey Yafang, > > Yafang Shao writes: > >- seq_printf(m, "pgscan %lu\n", acc.vmevents[PGSCAN_KSWAPD] + > >- acc.vmevents[PGSCAN_DIRECT]); > >+ seq_printf(m, "pgscan_direct %lu\n", acc.vmevents[PGSCAN_DIRECT]); > >+ seq_printf(m, "pgscan_kswapd %lu\n", acc.vmevents[PGSCAN_KSWAPD]); > > I don't think we can remove the overall pgscan counter now, we already have > people relying on it in prod. At least from my perspective, this patch would be > fine, as long as pgscan was kept. > HI Chirs, Thanks for your feedback. I will keep 'pgscan' and only introduce 'pgscan_kswapd'. Thanks Yafang
