On 4/7/19 6:30 PM, Qiang Yu wrote: > Thanks Randy, I can add these. > > Where should I send/submit the patch to in this case? Still drm-misc? Sounds good to me. Thanks. > Regards, > Qiang > > > On Mon, Apr 8, 2019 at 3:08 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: >> >> On 4/5/19 11:47 PM, kbuild test robot wrote: >>> Hi Andrew, >>> >>> It's probably a bug fix that unveils the link errors. >>> >>> tree: git://git.cmpxchg.org/linux-mmotm.git master >>> head: b09c000f671826e6f073a7f89b266e4ac998952b >>> commit: 39a08f353e1f30f7ba2e8b751a9034010a99666c [227/248] linux-next-git-rejects >>> config: sh-allyesconfig (attached as .config) >>> compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 >>> reproduce: >>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >>> chmod +x ~/bin/make.cross >>> git checkout 39a08f353e1f30f7ba2e8b751a9034010a99666c >>> # save the attached .config to linux build tree >>> GCC_VERSION=7.2.0 make.cross ARCH=sh >>> >>> All errors (new ones prefixed by >>): >>> >>> arch/sh/kernel/cpu/sh2/clock-sh7619.o:(.data+0x1c): undefined reference to `followparent_recalc' >>> drivers/gpu/drm/lima/lima_gem.o: In function `lima_gem_fault': >>>>> lima_gem.c:(.text+0x6c): undefined reference to `vmf_insert_mixed' >> >> >> vmf_insert_mixed() is only built for MMU configs, and the attached config >> does not set/enable MMU. >> Maybe this driver should depend on MMU, like several other drm drivers do. >> >> >> Also, lima_gem.c needs this line to be added to it: >> >> --- mmotm-2019-0405-1828.orig/drivers/gpu/drm/lima/lima_gem.c >> +++ mmotm-2019-0405-1828/drivers/gpu/drm/lima/lima_gem.c >> @@ -1,6 +1,7 @@ >> // SPDX-License-Identifier: GPL-2.0 OR MIT >> /* Copyright 2017-2019 Qiang Yu <yuq825@xxxxxxxxx> */ >> >> +#include <linux/mm.h> >> #include <linux/sync_file.h> >> #include <linux/pfn_t.h> >> >> >> >> -- >> ~Randy > -- ~Randy
