Re: [PATCH] mm/cma: Fix crash on CMA allocation if bitmap allocation fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 03/25/2019 01:43 PM, Yue Hu wrote:
> From: Yue Hu <huyue2@xxxxxxxxxx>
> 
> A previous commit f022d8cb7ec7 ("mm: cma: Don't crash on allocation
> if CMA area can't be activated") fixes the crash issue when activation
> fails via setting cma->count as 0, same logic exists if bitmap
> allocation fails.
> 
> Signed-off-by: Yue Hu <huyue2@xxxxxxxxxx>

Looks good to me. Just wondering if cma->count =  0 should be wrapped around in
a helper which explicitly states that this cma cannot be used for allocation.

Nonetheless.

Reviewed-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux