On Tue, Mar 19, 2019 at 5:47 AM Mike Kravetz <mike.kravetz@xxxxxxxxxx> wrote: > > > On 3/18/19 9:26 AM, Souptick Joarder wrote: > > kbuild produces the below warning -> > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > > head: 5453a3df2a5eb49bc24615d4cf0d66b2aae05e5f > > commit 3d3539018d2c ("mm: create the new vm_fault_t type") > > reproduce: > > # apt-get install sparse > > git checkout 3d3539018d2cbd12e5af4a132636ee7fd8d43ef0 > > make ARCH=x86_64 allmodconfig > > make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' > > > >>> mm/memory.c:3968:21: sparse: incorrect type in assignment (different > >>> base types) @@ expected restricted vm_fault_t [usertype] ret @@ > >>> got e] ret @@ > > mm/memory.c:3968:21: expected restricted vm_fault_t [usertype] ret > > mm/memory.c:3968:21: got int > > > > This patch will convert to return vm_fault_t type for hugetlb_fault() > > when CONFIG_HUGETLB_PAGE =n. > > > > Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx> > > Thanks for fixing this. > > The BUG() here and in several other places in this file is unnecessary > and IMO should be cleaned up. But that is beyond the scope of this fix. > Added to my to do list. I can clean it up if you are fine ;-) > > Reviewed-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx> > -- > Mike Kravetz
