On Wed, Mar 13, 2019 at 12:07:49PM -0400, Johannes Weiner wrote: > On Tue, Mar 12, 2019 at 03:34:04PM -0700, Roman Gushchin wrote: > > @@ -2180,50 +2179,8 @@ static int memcg_hotplug_cpu_dead(unsigned int cpu) > > + for_each_mem_cgroup(memcg) > > + memcg_flush_offline_percpu(memcg, get_cpu_mask(cpu)); > > cpumask_of(cpu) is the official API function, with kerneldoc and > everything. I think get_cpu_mask() is just an implementation helper. > > [hannes@computer linux]$ git grep cpumask_of | wc -l > 400 > [hannes@computer linux]$ git grep get_cpu_mask | wc -l > 20 > > Otherwise, looks good to me! Fixed in v3. Thank you!