On Wed, 2019-03-13 at 09:33 -0700, Andrew Morton wrote: > On Tue, 12 Mar 2019 15:50:36 -0700 Alexander Duyck <alexander.h.duyck@xxxxxxxxxxxxxxx> wrote: > > > On Tue, 2019-03-12 at 15:07 -0700, Andrew Morton wrote: > > > On Wed, 5 Dec 2018 21:42:47 +0100 Michal Hocko <mhocko@xxxxxxxxxx> wrote: > > > > > > > > I got your explanation. However Andrew had already applied the patches > > > > > and I had some outstanding issues in them that needed to be addressed. > > > > > So I thought it best to send out this set of patches with those fixes > > > > > before the code in mm became too stale. I am still working on what to > > > > > do about the Reserved bit, and plan to submit it as a follow-up set. > > > > > From my experience Andrew can drop patches between different versions of > > > > the patchset. Things can change a lot while they are in mmotm and under > > > > the discussion. > > > > > > It's been a while and everyone has forgotten everything, so I'll drop > > > this version of the patchset. > > > > > > > As far as getting to the reserved bit I probably won't have the time in > > the near future. If I were to resubmit the first 4 patches as a > > standalone patch set would that be acceptable, or would they be held up > > as well until the reserved bit issues is addressed? > > > > Yes, I think that merging the first four will be OK. As long as they > don't add some bug which [5/5] corrects, which happens sometimes! > > Please redo, retest and resend sometime? I had gone through and tested with each patch applied individually when I was performance testing them, and I am fairly certain there wasn't a bug introduced between any two patches. The issue that I recall Michal had was the fact that I was essentially embedding the setting of the reserved page under several layers of function calls, which would make it harder to remove. I started that work at about patch 5 which is why I figured I would resend the first 4, and hold off on 5-7 until I can get the reserved bit removal for hotplug done. I can probably have the patches ready to go in a couple days. I'll send updates once linux-next and mmotm with the patches dropped have been posted. Thanks. - Alex
