2011-04-14 (ë), 18:27 -0700, Hugh Dickins: > On Mon, Apr 11, 2011 at 5:27 AM, Namhyung Kim <namhyung@xxxxxxxxx> wrote: > > Split out some common code in shmem_truncate_range() in order to > > improve readability (hopefully) and to reduce code duplication. > > > > Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxx> > > Thank you for taking the trouble to do this. > > However... all that shmem_swp index code is irredeemably unreadable > (my fault, dating from when I converted it to use highmem with kmaps), > and I'd rather leave it untouched until we simply delete it > completely. > > I have a patch/set (good for my testing but not yet good for final > submission) which removes all that code, and the need to allocate > shmem_swp index pages (even when CONFIG_SWAP is not set!): instead > saving the swp_entries in the standard pagecache radix_tree for the > file, so no extra allocations are needed at all. > > It is possible that my patch/set will not be accepted (extending the > radix_tree in that way may meet some resistance); but I do think > that's the right way forward. > Looks reasonable. Please feel free to ignore this then, I'll look forward to your patches. Thanks. -- Regards, Namhyung Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>