We noticed a panic happening in production with the filemap fault pages because we were unlocking a NULL page. If add_to_page_cache() fails then we'll have a NULL page, so fix this check to only unlock if we have a valid page. Signed-off-by: Josef Bacik <josef@xxxxxxxxxxxxxx> --- mm/filemap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/filemap.c b/mm/filemap.c index cace3eb8069f..2815cb79a246 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1663,7 +1663,7 @@ struct page *pagecache_get_page(struct address_space *mapping, pgoff_t offset, * add_to_page_cache_lru locks the page, and for mmap we expect * an unlocked page. */ - if (fgp_flags & FGP_FOR_MMAP) + if (page && (fgp_flags & FGP_FOR_MMAP)) unlock_page(page); } -- 2.14.3
