On Mon, Mar 11, 2019 at 3:00 PM Qian Cai <cai@xxxxxx> wrote: > > On Mon, 2019-03-11 at 12:21 +0000, Jason Gunthorpe wrote: > > On Sun, Mar 10, 2019 at 08:58:15PM -0700, Davidlohr Bueso wrote: > > > On Sun, 10 Mar 2019, Qian Cai wrote: > > > > Not saying this patch shouldn't go ahead.. > > > > But is there a special reason the atomic64*'s on ppc don't use the u64 > > type like other archs? Seems like a better thing to fix than adding > > casts all over the place. > > > > A bit of history here, > > https://patchwork.kernel.org/patch/7344011/#15495901 Ah, I had already forgotten about that discussion. At least the atomic_long part we discussed there has been resolved now as part of commit b5d47ef9ea5c ("locking/atomics: Switch to generated atomic-long"). Adding Mark Rutland to Cc, maybe he has some ideas of how to use the infrastructure he added to use consistent types for atomic64() on the remaining 64-bit architectures. Arnd