On Fri 08-03-19 16:01:05, Peter Zijlstra wrote: > On Fri, Mar 08, 2019 at 12:58:02PM +0100, Michal Hocko wrote: > > On Fri 08-03-19 12:54:13, Michal Hocko wrote: > > > [Cc Petr for the lockdep part - the patch is > > > http://lkml.kernel.org/r/1552040522-9085-1-git-send-email-penguin-kernel@xxxxxxxxxxxxxxxxxxx] > > > > now for real. > > That really wants a few more comments; I _think_ it is ok, but *shees*. It would be also great to pull it out of the code flow and hide it behind a helper static inline. Something like lockdep_track_oom_alloc_reentrant or a like. -- Michal Hocko SUSE Labs