On Thu, Mar 7, 2019 at 7:53 PM Qian Cai <cai@xxxxxx> wrote:
>
> set_tag() compiles away when CONFIG_KASAN_SW_TAGS=n, so make
> arch_kasan_set_tag() a static inline function to fix warnings below.
>
> mm/kasan/common.c: In function '__kasan_kmalloc':
> mm/kasan/common.c:475:5: warning: variable 'tag' set but not used
> [-Wunused-but-set-variable]
> u8 tag;
> ^~~
>
> Signed-off-by: Qian Cai <cai@xxxxxx>
> ---
> mm/kasan/kasan.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h
> index 3e0c11f7d7a1..3ce956efa0cb 100644
> --- a/mm/kasan/kasan.h
> +++ b/mm/kasan/kasan.h
> @@ -163,7 +163,10 @@ static inline u8 random_tag(void)
> #endif
>
> #ifndef arch_kasan_set_tag
> -#define arch_kasan_set_tag(addr, tag) ((void *)(addr))
> +static inline const void *arch_kasan_set_tag(const void *addr, u8 tag)
> +{
> + return addr;
> +}
> #endif
> #ifndef arch_kasan_reset_tag
> #define arch_kasan_reset_tag(addr) ((void *)(addr))
> --
> 2.17.2 (Apple Git-113)
>
Reviewed-by: Andrey Konovalov <andreyknvl@xxxxxxxxxx>
Thanks!
