Re: [PATCH] mm/thp: Use conventional format for boolean attributes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 14 Apr 2011, Andrew Morton wrote:

> From: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> 
> The conventional format for boolean attributes in sysfs is numeric ("0" or
> "1" followed by new-line).  Any boolean attribute can then be read and
> written using a generic function.  Using the strings "yes [no]", "[yes]
> no" (read), "yes" and "no" (write) will frustrate this.
> 
> [akpm@xxxxxxxxxxxxxxxxxxxx: use kstrtoul()]
> [akpm@xxxxxxxxxxxxxxxxxxxx: test_bit() doesn't return 1/0, per Neil]
> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> Cc: Andrea Arcangeli <aarcange@xxxxxxxxxx>
> Cc: Mel Gorman <mel@xxxxxxxxx>
> Cc: Johannes Weiner <jweiner@xxxxxxxxxx>
> Cc: Rik van Riel <riel@xxxxxxxxxx>
> Cc: Hugh Dickins <hughd@xxxxxxxxxx>
> Cc: David Rientjes <rientjes@xxxxxxxxxx>
> Cc: NeilBrown <neilb@xxxxxxx>
> Cc: <stable@xxxxxxxxxx> 	[2.6.38.x]
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

Tested-by: David Rientjes <rientjes@xxxxxxxxxx>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]