On Mon, Mar 04, 2019 at 10:33:52AM +0000, Peng Fan wrote: > pcpu_find_block_fit is not find block index, it is to find > the bitmap off in a chunk. > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx> > --- > > V1: > Based on https://patchwork.kernel.org/cover/10832459/ applied linux-next > > mm/percpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/percpu.c b/mm/percpu.c > index 7f630d5469e8..5ee90fc34ea3 100644 > --- a/mm/percpu.c > +++ b/mm/percpu.c > @@ -1061,7 +1061,7 @@ static bool pcpu_is_populated(struct pcpu_chunk *chunk, int bit_off, int bits, > } > > /** > - * pcpu_find_block_fit - finds the block index to start searching > + * pcpu_find_block_fit - finds the offset in chunk bitmap to start searching > * @chunk: chunk of interest > * @alloc_bits: size of request in allocation units > * @align: alignment of area (max PAGE_SIZE bytes) > -- > 2.16.4 > So really the block index is encoded in the bit offset. I'm not super happy with either wording because the point of the function really is to find a block(s) that can support this allocation and it happens the output is a chunk offset. Thanks, Dennis
