Hi,
On Wed, Feb 27, 2019 at 08:27:40PM +0100, Geert Uytterhoeven wrote:
> Hi Steven,
>
> On Wed, Feb 27, 2019 at 6:07 PM Steven Price <steven.price@xxxxxxx> wrote:
> > walk_page_range() is going to be allowed to walk page tables other than
> > those of user space. For this it needs to know when it has reached a
> > 'leaf' entry in the page tables. This information is provided by the
> > p?d_large() functions/macros.
> >
> > For m68k, we don't support large pages, so add stubs returning 0
> >
> > CC: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > CC: linux-m68k@xxxxxxxxxxxxxxxxxxxx
> > Signed-off-by: Steven Price <steven.price@xxxxxxx>
>
> Thanks for your patch!
>
> > arch/m68k/include/asm/mcf_pgtable.h | 2 ++
> > arch/m68k/include/asm/motorola_pgtable.h | 2 ++
> > arch/m68k/include/asm/pgtable_no.h | 1 +
> > arch/m68k/include/asm/sun3_pgtable.h | 2 ++
> > 4 files changed, 7 insertions(+)
>
> If the definitions are the same, why not add them to
> arch/m68k/include/asm/pgtable.h instead?
Maybe I'm missing something, but why the stubs have to be defined in
arch/*/include/asm/pgtable.h rather than in include/asm-generic/pgtable.h?
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
--
Sincerely yours,
Mike.
