On Mon, 25 Feb 2019, Dennis Zhou wrote: > > @@ -27,7 +27,7 @@ > > * chunk size is not aligned. percpu-km code will whine about it. > > */ > > > > -#if defined(CONFIG_SMP) && defined(CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK) > > +#if defined(CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK) > > #error "contiguous percpu allocation is incompatible with paged first chunk" > > #endif > > > > -- > > 2.16.4 > > > > Hi, > > I think keeping CONFIG_SMP makes this easier to remember dependencies > rather than having to dig into the config. So this is a NACK from me. But it simplifies the code and makes it easier to read.
