Hi Yafang, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/perf/core] [also build test ERROR on v5.0-rc8 next-20190226] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Yafang-Shao/mm-compaction-remove-unnecessary-CONFIG_COMPACTION/20190226-154127 config: x86_64-randconfig-k3-02241946 (attached as .config) compiler: gcc-8 (Debian 8.2.0-20) 8.2.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All error/warnings (new ones prefixed by >>): In file included from include/trace/define_trace.h:96, from include/trace/events/compaction.h:355, from mm/compaction.c:46: include/trace/events/compaction.h: In function 'trace_raw_output_mm_compaction_end': include/trace/trace_events.h:299:18: error: expected expression before ',' token { symbol_array, { -1, NULL }}; \ ^ include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS' trace_seq_printf(s, print); \ ^~~~~ include/trace/trace_events.h:79:9: note: in expansion of macro 'PARAMS' PARAMS(print)); \ ^~~~~~ include/trace/events/compaction.h:135:1: note: in expansion of macro 'TRACE_EVENT' TRACE_EVENT(mm_compaction_end, ^~~~~~~~~~~ include/trace/events/compaction.h:160:2: note: in expansion of macro 'TP_printk' TP_printk("zone_start=0x%lx migrate_pfn=0x%lx free_pfn=0x%lx zone_end=0x%lx, mode=%s status=%s", ^~~~~~~~~ include/trace/events/compaction.h:166:3: note: in expansion of macro '__print_symbolic' __print_symbolic(__entry->status, COMPACTION_STATUS)) ^~~~~~~~~~~~~~~~ include/trace/events/compaction.h: In function 'trace_raw_output_mm_compaction_suitable_template': include/trace/trace_events.h:299:18: error: expected expression before ',' token { symbol_array, { -1, NULL }}; \ ^ include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS' trace_seq_printf(s, print); \ ^~~~~ include/trace/events/compaction.h:218:2: note: in expansion of macro 'TP_printk' TP_printk("node=%d zone=%-8s order=%d ret=%s", ^~~~~~~~~ include/trace/events/compaction.h:222:3: note: in expansion of macro '__print_symbolic' __print_symbolic(__entry->ret, COMPACTION_STATUS)) ^~~~~~~~~~~~~~~~ include/trace/trace_events.h:299:18: warning: initialization of 'long unsigned int' from 'const struct trace_print_flags *' makes integer from pointer without a cast [-Wint-conversion] { symbol_array, { -1, NULL }}; \ ^ include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS' trace_seq_printf(s, print); \ ^~~~~ include/trace/events/compaction.h:218:2: note: in expansion of macro 'TP_printk' TP_printk("node=%d zone=%-8s order=%d ret=%s", ^~~~~~~~~ include/trace/events/compaction.h:222:3: note: in expansion of macro '__print_symbolic' __print_symbolic(__entry->ret, COMPACTION_STATUS)) ^~~~~~~~~~~~~~~~ include/trace/trace_events.h:299:18: note: (near initialization for 'symbols[0].mask') { symbol_array, { -1, NULL }}; \ ^ include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS' trace_seq_printf(s, print); \ ^~~~~ include/trace/events/compaction.h:218:2: note: in expansion of macro 'TP_printk' TP_printk("node=%d zone=%-8s order=%d ret=%s", ^~~~~~~~~ include/trace/events/compaction.h:222:3: note: in expansion of macro '__print_symbolic' __print_symbolic(__entry->ret, COMPACTION_STATUS)) ^~~~~~~~~~~~~~~~ include/trace/trace_events.h:299:18: error: initializer element is not constant { symbol_array, { -1, NULL }}; \ ^ include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS' trace_seq_printf(s, print); \ ^~~~~ include/trace/events/compaction.h:218:2: note: in expansion of macro 'TP_printk' TP_printk("node=%d zone=%-8s order=%d ret=%s", ^~~~~~~~~ include/trace/events/compaction.h:222:3: note: in expansion of macro '__print_symbolic' __print_symbolic(__entry->ret, COMPACTION_STATUS)) ^~~~~~~~~~~~~~~~ include/trace/trace_events.h:299:18: note: (near initialization for 'symbols[0].mask') { symbol_array, { -1, NULL }}; \ ^ include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS' trace_seq_printf(s, print); \ ^~~~~ include/trace/events/compaction.h:218:2: note: in expansion of macro 'TP_printk' TP_printk("node=%d zone=%-8s order=%d ret=%s", ^~~~~~~~~ include/trace/events/compaction.h:222:3: note: in expansion of macro '__print_symbolic' __print_symbolic(__entry->ret, COMPACTION_STATUS)) ^~~~~~~~~~~~~~~~ In file included from include/trace/define_trace.h:96, from include/trace/events/compaction.h:355, from mm/compaction.c:46: include/trace/events/compaction.h: In function 'trace_event_raw_event_mm_compaction_defer_template': >> include/trace/events/compaction.h:262:31: error: 'struct zone' has no member named 'compact_considered'; did you mean 'compact_cached_free_pfn'? __entry->considered = zone->compact_considered; ^~~~~~~~~~~~~~~~~~ include/trace/trace_events.h:720:4: note: in definition of macro 'DECLARE_EVENT_CLASS' { assign; } \ ^~~~~~ include/trace/events/compaction.h:258:2: note: in expansion of macro 'TP_fast_assign' TP_fast_assign( ^~~~~~~~~~~~~~ >> include/trace/events/compaction.h:262:23: warning: assignment to 'unsigned int' from 'const struct trace_print_flags *' makes integer from pointer without a cast [-Wint-conversion] __entry->considered = zone->compact_considered; ^ include/trace/trace_events.h:720:4: note: in definition of macro 'DECLARE_EVENT_CLASS' { assign; } \ ^~~~~~ include/trace/events/compaction.h:258:2: note: in expansion of macro 'TP_fast_assign' TP_fast_assign( ^~~~~~~~~~~~~~ >> include/trace/events/compaction.h:263:30: error: 'struct zone' has no member named 'compact_defer_shift' __entry->defer_shift = zone->compact_defer_shift; ^~ include/trace/trace_events.h:720:4: note: in definition of macro 'DECLARE_EVENT_CLASS' { assign; } \ ^~~~~~ include/trace/events/compaction.h:258:2: note: in expansion of macro 'TP_fast_assign' TP_fast_assign( ^~~~~~~~~~~~~~ include/trace/events/compaction.h:263:24: warning: assignment to 'unsigned int' from 'const struct trace_print_flags *' makes integer from pointer without a cast [-Wint-conversion] __entry->defer_shift = zone->compact_defer_shift; ^ include/trace/trace_events.h:720:4: note: in definition of macro 'DECLARE_EVENT_CLASS' { assign; } \ ^~~~~~ include/trace/events/compaction.h:258:2: note: in expansion of macro 'TP_fast_assign' TP_fast_assign( ^~~~~~~~~~~~~~ >> include/trace/events/compaction.h:264:31: error: 'struct zone' has no member named 'compact_order_failed' __entry->order_failed = zone->compact_order_failed; ^~ include/trace/trace_events.h:720:4: note: in definition of macro 'DECLARE_EVENT_CLASS' { assign; } \ ^~~~~~ include/trace/events/compaction.h:258:2: note: in expansion of macro 'TP_fast_assign' TP_fast_assign( ^~~~~~~~~~~~~~ >> include/trace/events/compaction.h:264:25: warning: assignment to 'int' from 'const struct trace_print_flags *' makes integer from pointer without a cast [-Wint-conversion] __entry->order_failed = zone->compact_order_failed; ^ include/trace/trace_events.h:720:4: note: in definition of macro 'DECLARE_EVENT_CLASS' { assign; } \ ^~~~~~ include/trace/events/compaction.h:258:2: note: in expansion of macro 'TP_fast_assign' TP_fast_assign( ^~~~~~~~~~~~~~ In file included from include/trace/define_trace.h:97, from include/trace/events/compaction.h:355, from mm/compaction.c:46: include/trace/events/compaction.h: In function 'perf_trace_mm_compaction_defer_template': >> include/trace/events/compaction.h:262:31: error: 'struct zone' has no member named 'compact_considered'; did you mean 'compact_cached_free_pfn'? __entry->considered = zone->compact_considered; ^~~~~~~~~~~~~~~~~~ include/trace/perf.h:66:4: note: in definition of macro 'DECLARE_EVENT_CLASS' { assign; } \ ^~~~~~ include/trace/events/compaction.h:258:2: note: in expansion of macro 'TP_fast_assign' TP_fast_assign( ^~~~~~~~~~~~~~ >> include/trace/events/compaction.h:262:23: warning: assignment to 'unsigned int' from 'const struct trace_print_flags *' makes integer from pointer without a cast [-Wint-conversion] __entry->considered = zone->compact_considered; ^ include/trace/perf.h:66:4: note: in definition of macro 'DECLARE_EVENT_CLASS' { assign; } \ ^~~~~~ include/trace/events/compaction.h:258:2: note: in expansion of macro 'TP_fast_assign' TP_fast_assign( ^~~~~~~~~~~~~~ >> include/trace/events/compaction.h:263:30: error: 'struct zone' has no member named 'compact_defer_shift' __entry->defer_shift = zone->compact_defer_shift; ^~ include/trace/perf.h:66:4: note: in definition of macro 'DECLARE_EVENT_CLASS' { assign; } \ ^~~~~~ include/trace/events/compaction.h:258:2: note: in expansion of macro 'TP_fast_assign' TP_fast_assign( ^~~~~~~~~~~~~~ include/trace/events/compaction.h:263:24: warning: assignment to 'unsigned int' from 'const struct trace_print_flags *' makes integer from pointer without a cast [-Wint-conversion] __entry->defer_shift = zone->compact_defer_shift; ^ include/trace/perf.h:66:4: note: in definition of macro 'DECLARE_EVENT_CLASS' { assign; } \ ^~~~~~ include/trace/events/compaction.h:258:2: note: in expansion of macro 'TP_fast_assign' TP_fast_assign( ^~~~~~~~~~~~~~ >> include/trace/events/compaction.h:264:31: error: 'struct zone' has no member named 'compact_order_failed' __entry->order_failed = zone->compact_order_failed; ^~ include/trace/perf.h:66:4: note: in definition of macro 'DECLARE_EVENT_CLASS' { assign; } \ ^~~~~~ include/trace/events/compaction.h:258:2: note: in expansion of macro 'TP_fast_assign' TP_fast_assign( ^~~~~~~~~~~~~~ >> include/trace/events/compaction.h:264:25: warning: assignment to 'int' from 'const struct trace_print_flags *' makes integer from pointer without a cast [-Wint-conversion] __entry->order_failed = zone->compact_order_failed; ^ include/trace/perf.h:66:4: note: in definition of macro 'DECLARE_EVENT_CLASS' { assign; } \ ^~~~~~ include/trace/events/compaction.h:258:2: note: in expansion of macro 'TP_fast_assign' TP_fast_assign( ^~~~~~~~~~~~~~ vim +262 include/trace/events/compaction.h 837d026d5 Joonsoo Kim 2015-02-11 197 837d026d5 Joonsoo Kim 2015-02-11 198 TP_PROTO(struct zone *zone, 837d026d5 Joonsoo Kim 2015-02-11 199 int order, 837d026d5 Joonsoo Kim 2015-02-11 200 int ret), 837d026d5 Joonsoo Kim 2015-02-11 201 837d026d5 Joonsoo Kim 2015-02-11 202 TP_ARGS(zone, order, ret), 837d026d5 Joonsoo Kim 2015-02-11 203 837d026d5 Joonsoo Kim 2015-02-11 204 TP_STRUCT__entry( 837d026d5 Joonsoo Kim 2015-02-11 205 __field(int, nid) 1743d0506 Vlastimil Babka 2015-11-05 206 __field(enum zone_type, idx) 837d026d5 Joonsoo Kim 2015-02-11 207 __field(int, order) 837d026d5 Joonsoo Kim 2015-02-11 208 __field(int, ret) 837d026d5 Joonsoo Kim 2015-02-11 209 ), 837d026d5 Joonsoo Kim 2015-02-11 210 837d026d5 Joonsoo Kim 2015-02-11 211 TP_fast_assign( 837d026d5 Joonsoo Kim 2015-02-11 212 __entry->nid = zone_to_nid(zone); 1743d0506 Vlastimil Babka 2015-11-05 213 __entry->idx = zone_idx(zone); 837d026d5 Joonsoo Kim 2015-02-11 214 __entry->order = order; 837d026d5 Joonsoo Kim 2015-02-11 215 __entry->ret = ret; 837d026d5 Joonsoo Kim 2015-02-11 216 ), 837d026d5 Joonsoo Kim 2015-02-11 217 837d026d5 Joonsoo Kim 2015-02-11 218 TP_printk("node=%d zone=%-8s order=%d ret=%s", 837d026d5 Joonsoo Kim 2015-02-11 219 __entry->nid, 1743d0506 Vlastimil Babka 2015-11-05 220 __print_symbolic(__entry->idx, ZONE_TYPE), 837d026d5 Joonsoo Kim 2015-02-11 221 __entry->order, fa6c7b46a Vlastimil Babka 2015-11-05 @222 __print_symbolic(__entry->ret, COMPACTION_STATUS)) 837d026d5 Joonsoo Kim 2015-02-11 223 ); 837d026d5 Joonsoo Kim 2015-02-11 224 837d026d5 Joonsoo Kim 2015-02-11 225 DEFINE_EVENT(mm_compaction_suitable_template, mm_compaction_finished, 837d026d5 Joonsoo Kim 2015-02-11 226 837d026d5 Joonsoo Kim 2015-02-11 227 TP_PROTO(struct zone *zone, 837d026d5 Joonsoo Kim 2015-02-11 228 int order, 837d026d5 Joonsoo Kim 2015-02-11 229 int ret), 837d026d5 Joonsoo Kim 2015-02-11 230 837d026d5 Joonsoo Kim 2015-02-11 231 TP_ARGS(zone, order, ret) 837d026d5 Joonsoo Kim 2015-02-11 232 ); 837d026d5 Joonsoo Kim 2015-02-11 233 837d026d5 Joonsoo Kim 2015-02-11 234 DEFINE_EVENT(mm_compaction_suitable_template, mm_compaction_suitable, 837d026d5 Joonsoo Kim 2015-02-11 235 837d026d5 Joonsoo Kim 2015-02-11 236 TP_PROTO(struct zone *zone, 837d026d5 Joonsoo Kim 2015-02-11 237 int order, 837d026d5 Joonsoo Kim 2015-02-11 238 int ret), 837d026d5 Joonsoo Kim 2015-02-11 239 837d026d5 Joonsoo Kim 2015-02-11 240 TP_ARGS(zone, order, ret) 837d026d5 Joonsoo Kim 2015-02-11 241 ); 837d026d5 Joonsoo Kim 2015-02-11 242 24e2716f6 Joonsoo Kim 2015-02-11 243 DECLARE_EVENT_CLASS(mm_compaction_defer_template, 24e2716f6 Joonsoo Kim 2015-02-11 244 24e2716f6 Joonsoo Kim 2015-02-11 245 TP_PROTO(struct zone *zone, int order), 24e2716f6 Joonsoo Kim 2015-02-11 246 24e2716f6 Joonsoo Kim 2015-02-11 247 TP_ARGS(zone, order), 24e2716f6 Joonsoo Kim 2015-02-11 248 24e2716f6 Joonsoo Kim 2015-02-11 249 TP_STRUCT__entry( 24e2716f6 Joonsoo Kim 2015-02-11 250 __field(int, nid) 1743d0506 Vlastimil Babka 2015-11-05 251 __field(enum zone_type, idx) 24e2716f6 Joonsoo Kim 2015-02-11 252 __field(int, order) 24e2716f6 Joonsoo Kim 2015-02-11 253 __field(unsigned int, considered) 24e2716f6 Joonsoo Kim 2015-02-11 254 __field(unsigned int, defer_shift) 24e2716f6 Joonsoo Kim 2015-02-11 255 __field(int, order_failed) 24e2716f6 Joonsoo Kim 2015-02-11 256 ), 24e2716f6 Joonsoo Kim 2015-02-11 257 24e2716f6 Joonsoo Kim 2015-02-11 258 TP_fast_assign( 24e2716f6 Joonsoo Kim 2015-02-11 259 __entry->nid = zone_to_nid(zone); 1743d0506 Vlastimil Babka 2015-11-05 260 __entry->idx = zone_idx(zone); 24e2716f6 Joonsoo Kim 2015-02-11 261 __entry->order = order; 24e2716f6 Joonsoo Kim 2015-02-11 @262 __entry->considered = zone->compact_considered; 24e2716f6 Joonsoo Kim 2015-02-11 @263 __entry->defer_shift = zone->compact_defer_shift; 24e2716f6 Joonsoo Kim 2015-02-11 @264 __entry->order_failed = zone->compact_order_failed; 24e2716f6 Joonsoo Kim 2015-02-11 265 ), 24e2716f6 Joonsoo Kim 2015-02-11 266 24e2716f6 Joonsoo Kim 2015-02-11 267 TP_printk("node=%d zone=%-8s order=%d order_failed=%d consider=%u limit=%lu", 24e2716f6 Joonsoo Kim 2015-02-11 268 __entry->nid, 1743d0506 Vlastimil Babka 2015-11-05 269 __print_symbolic(__entry->idx, ZONE_TYPE), 24e2716f6 Joonsoo Kim 2015-02-11 270 __entry->order, 24e2716f6 Joonsoo Kim 2015-02-11 271 __entry->order_failed, 24e2716f6 Joonsoo Kim 2015-02-11 272 __entry->considered, 24e2716f6 Joonsoo Kim 2015-02-11 273 1UL << __entry->defer_shift) 24e2716f6 Joonsoo Kim 2015-02-11 274 ); 24e2716f6 Joonsoo Kim 2015-02-11 275 :::::: The code at line 262 was first introduced by commit :::::: 24e2716f63e613cf15d3beba3faa0711bcacc427 mm/compaction: add tracepoint to observe behaviour of compaction defer :::::: TO: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx> :::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
