From: Yue Hu <huyue2@xxxxxxxxxx> If debugfs_create_dir() failed, the following debugfs_create_file() will be meanless since it depends on non-NULL tmp dentry and it will only waste CPU resource. Signed-off-by: Yue Hu <huyue2@xxxxxxxxxx> --- mm/cma_debug.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/cma_debug.c b/mm/cma_debug.c index 2c2c869..3e9d984 100644 --- a/mm/cma_debug.c +++ b/mm/cma_debug.c @@ -169,6 +169,8 @@ static void cma_debugfs_add_one(struct cma *cma, struct dentry *root_dentry) scnprintf(name, sizeof(name), "cma-%s", cma->name); tmp = debugfs_create_dir(name, root_dentry); + if (!tmp) + return; debugfs_create_file("alloc", 0200, tmp, cma, &cma_alloc_fops); debugfs_create_file("free", 0200, tmp, cma, &cma_free_fops); -- 1.9.1