On 2/1/19 12:43 AM, Christoph Hellwig wrote:
> On Mon, Jan 28, 2019 at 12:18:05PM -0800, Matthew Wilcox wrote:
>> On Mon, Jan 28, 2019 at 08:31:19PM +0800, zhengbin wrote:
>>> The 'end_byte' parameter of filemap_range_has_page is required to be
>>> inclusive, so follow the rule.
>>
>> Reviewed-by: Matthew Wilcox <willy@xxxxxxxxxxxxx>
>> Fixes: 6be96d3ad34a ("fs: return if direct I/O will trigger writeback")
>>
>> Adding the people in the sign-off chain to the Cc.
>
> This looks correct to me:
>
> Acked-by: Christoph Hellwig <hch@xxxxxx>
Ditto
> I wish we'd kill these stupid range calling conventions, though -
> offset + len is a lot more intuitive, and we already use it very
> widely all over the kernel.
Wholeheartedly agree on that, it's a horrible interface that goes
counter to the whole "easy to use, hard to misuse" mantra.
--
Jens Axboe
