On Mon, Apr 11, 2011 at 5:00 PM, KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> wrote: > Commit bce7394a3e (page-allocator: reset wmark_min and inactive ratio of > zone when hotplug happens) introduced invalid section references. > Now, setup_per_zone_inactive_ratio() is marked __init and then it can't > be referenced from memory hotplug code. > > Then, this patch marks it as __meminit and also marks caller as __ref. > > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> Reviewed-by: Minchan Kim <minchan.kim@xxxxxxxxx> Just a nitpick. As below comment of __ref said, It would be better to add _why_ such as memory_hotplug.c. "so optimally document why the __ref is needed and why it's OK" Anyway, Thanks, KOSAKI. -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>