On Thu, Jan 24, 2019 at 03:05:03PM +0800, Peter Xu wrote: > On Mon, Jan 21, 2019 at 11:24:55AM -0500, Jerome Glisse wrote: > > On Mon, Jan 21, 2019 at 03:57:02PM +0800, Peter Xu wrote: > > > This is the gup counterpart of the change that allows the VM_FAULT_RETRY > > > to happen for more than once. > > > > > > Signed-off-by: Peter Xu <peterx@xxxxxxxxxx> > > > > So it would be nice to add a comment in the code and in the commit message > > about possible fault starvation (mostly due to previous patch changes) as > > if some one experience that and try to bisect it might overlook the commit. > > > > Otherwise: > > > > Reviewed-by: Jérôme Glisse <jglisse@xxxxxxxxxx> > > Jerome, can I still keep this r-b if I'm going to fix the starvation > issue you mentioned in previous patch about lock page? > No please, i still want to review properly the oneline ie making sure that it will not change any of the existing use of FAULT_FLAG_TRIED I am finishing a bunch of patches myself so i am bit short on time right now to take a deeper look but i will try to do that in next few days :) In anycase i will review again your next posting. Cheers, Jérôme
