On Tue 22-01-19 15:56:28, Wei Yang wrote: > On Tue, Jan 22, 2019 at 04:16:28PM +0100, Michal Hocko wrote: > >On Tue 22-01-19 15:07:17, Wei Yang wrote: > >> On Tue, Jan 22, 2019 at 09:55:24AM +0100, Michal Hocko wrote: > >> >On Sat 19-01-19 07:49:05, Wei Yang wrote: > >> >> Two cleanups in this patch: > >> >> > >> >> * since pageblock_nr_pages == (1 << pageblock_order), the roundup() > >> >> and right shift pageblock_order could be replaced with > >> >> DIV_ROUND_UP() > >> > > >> >Why is this change worth it? > >> > > >> > >> To make it directly show usemapsize is number of times of > >> pageblock_nr_pages. > > > >Does this lead to a better code generation? Does it make the code easier > >to read/maintain? > > > > I think the answer is yes. > > * it reduce the code from 6 lines to 3 lines, 50% off > * by reducing calculation back and forth, it would be easier for > audience to catch what it tries to do To be honest, I really do not see this sufficient to justify touching the code unless the resulting _generated_ code is better/more efficient. -- Michal Hocko SUSE Labs
