On Thu, Jan 17, 2019 at 03:19:35AM -0700, William Kucharski wrote: > > This seems very reasonable, but if the code is just going to panic if the > allocation fails, why not call memblock_alloc_node() instead? I've sent patches [1] that remove panic() from memblock_alloc*() and drop _nopanic variants. After they will be (hopefully) merged, memblock_alloc_node() will return NULL on error. > If there is a reason we'd prefer to call memblock_alloc_node_nopanic(), > I'd like to see pgdat->nodeid printed in the panic message as well. Sure. [1] https://lore.kernel.org/lkml/1547646261-32535-1-git-send-email-rppt@xxxxxxxxxxxxx/ -- Sincerely yours, Mike.
