On Tue, Jan 15, 2019 at 12:50:45PM +0000, Mel Gorman wrote: > > AFAICS memory allocator is not the only user of PageReserved. There > > seems to be some drivers as well, notably the DRM subsystem via > > drm_pci_alloc(). There's an effort to clean those up [1] but until then, > > there might be some false positives here. > > > > [1] https://marc.info/?l=linux-mm&m=154747078617898&w=2 > > > > Hmm, I'm tempted to leave this anyway. The reservations for PCI space are > likely to be persistent and I also do not expect them to grow much. While > I consider it to be partially abuse to use PageReserved like this, it > should get cleaned up slowly over time. If this turns out to be wrong, > I'll attempt to fix the responsible driver that is scattering > PageReserved around the place and at worst, revert this if it turns out > to be a major problem in practice. Any objections? > I decided to drop this anyway as the series does not hinge on it, it's a relatively minor improvement overall and I don't want to halt the entire series over it. The maintain that the system would recover even if the driver released the pages as the check would eventually fail and then be cleared after a reset. The only downside from the patch that I can see really is that it's a small maintenance overhead due to an apparent duplicated check. The CPU overhead of compaction will be slightly higher due to the revert but there are other options on the horizon that would bring down that overhead again. -- Mel Gorman SUSE Labs
