On Tue, Jan 15, 2019 at 6:09 PM Keith Busch <keith.busch@xxxxxxxxx> wrote: > > On Thu, Jan 10, 2019 at 07:42:46AM -0800, Rafael J. Wysocki wrote: > > On Wed, Jan 9, 2019 at 6:47 PM Keith Busch <keith.busch@xxxxxxxxx> wrote: > > > > > > Systems may provide different memory types and export this information > > > in the ACPI Heterogeneous Memory Attribute Table (HMAT). Parse these > > > tables provided by the platform and report the memory access and caching > > > attributes. > > > > > > Signed-off-by: Keith Busch <keith.busch@xxxxxxxxx> > > > > While this is generally fine by me, it's another piece of code going > > under drivers/acpi/ just because it happens to use ACPI to extract > > some information from the platform firmware. > > > > Isn't there any better place for it? > > I've tried to abstract the user visible parts outside any particular > firmware implementation, but HMAT parsing is an ACPI specific feature, > so I thought ACPI was a good home for this part. I'm open to suggestions > if there's a better place. Either under in another existing subsystem, > or create a new one under drivers/hmat/? Well, there is drivers/acpi/nfit for the NVDIMM-related things, so maybe there could be drivers/acpi/mm/ containing nfit/ and hmat.c (and maybe some other mm-related things)?