On 01/14/2019 12:31 PM, Michal Hocko wrote: > On Mon 14-01-19 09:30:55, Anshuman Khandual wrote: >> >> >> On 01/13/2019 11:05 PM, Michal Hocko wrote: >>> On Sat 12-01-19 15:56:38, Anshuman Khandual wrote: >>>> All architectures have been defining their own PGALLOC_GFP as (GFP_KERNEL | >>>> __GFP_ZERO) and using it for allocating page table pages. This causes some >>>> code duplication which can be easily avoided. GFP_KERNEL allocated and >>>> cleared out pages (__GFP_ZERO) are required for page tables on any given >>>> architecture. This creates a new generic GFP flag flag which can be used >>>> for any page table page allocation. Does not cause any functional change. >>> >>> I agree that some unification is due but GFP_PGTABLE is not something to >>> expose in generic gfp.h IMHO. It just risks an abuse. I would be looking >> >> Why would you think that it risks an abuse ? It does not create new semantics >> of allocation in the buddy. Its just uses existing GFP_KERNEL allocation which >> is then getting zeroed out. The risks (if any) is exactly same as GFP_KERNEL. > > Beucase my experience just tells me that people tend to use whatever > they find and name fits what they think they need. > >>> at providing asm-generic implementation and reuse it to remove the code >> >> Does that mean GFP_PGTABLE can be created but not in gfp.h but in some other >> memory related header file ? > > I would just keep it close to its users. If that is a single arch > generic place then only better. But I suspect some arches have special > requirements. We can move the definition into include/asm-generic/pgtable.h which can be used by all archs. If there any special requirements those can be added on this generic and common minimum allocation flag. The minimum required flag should not be duplicated every where. > >>> duplication. But I haven't tried that to know that it will work out due >>> to small/subtle differences between arches. >> >> IIUC from the allocation perspective GFP_ACCOUNT is the only thing which gets >> added with GFP_PGTABLE for user page table for memcg accounting purpose. There >> does not seem to be any other differences unless I am missing something. > > It's been some time since I've checked the last time. Some arches were > using GPF_REPEAT (__GFP_RETRY_MAYFAIL) back then. I have removed most of > those but some were doing a higher order allocations so they probably > have stayed. A simple grep shows that still there are some places which use the flag __GFP_RETRY_MAYFAIL. But that can be added on GFP_PGTABLE for these archs. arch/nds32/include/asm/pgalloc.h: (pte_t *) __get_free_page(GFP_KERNEL | __GFP_RETRY_MAYFAIL | arch/nds32/include/asm/pgalloc.h: pte = alloc_pages(GFP_KERNEL | __GFP_RETRY_MAYFAIL | __GFP_ZERO, 0); arch/powerpc/include/asm/book3s/64/pgalloc.h: page = alloc_pages(pgtable_gfp_flags(mm, PGALLOC_GFP | __GFP_RETRY_MAYFAIL), arch/powerpc/kvm/book3s_64_mmu_hv.c: hpt = __get_free_pages(GFP_KERNEL|__GFP_ZERO|__GFP_RETRY_MAYFAIL arch/riscv/include/asm/pgalloc.h: GFP_KERNEL | __GFP_RETRY_MAYFAIL | __GFP_ZERO); arch/riscv/include/asm/pgalloc.h: GFP_KERNEL | __GFP_RETRY_MAYFAIL | __GFP_ZERO); arch/riscv/include/asm/pgalloc.h: pte = alloc_page(GFP_KERNEL | __GFP_RETRY_MAYFAIL | __GFP_ZERO); arch/sparc/kernel/mdesc.c: base = kmalloc(handle_size + 15, GFP_KERNEL | __GFP_RETRY_MAYFAIL);
