On Fri, Jan 11, 2019 at 07:06:08PM -0800, John Hubbard wrote: > On 1/11/19 6:46 PM, Jerome Glisse wrote: > > On Fri, Jan 11, 2019 at 06:38:44PM -0800, John Hubbard wrote: > >> On 1/11/19 6:02 PM, Jerome Glisse wrote: > >>> On Fri, Jan 11, 2019 at 05:04:05PM -0800, John Hubbard wrote: > >>>> On 1/11/19 8:51 AM, Jerome Glisse wrote: > >>>>> On Thu, Jan 10, 2019 at 06:59:31PM -0800, John Hubbard wrote: > >>>>>> On 1/3/19 6:44 AM, Jerome Glisse wrote: > >>>>>>> On Thu, Jan 03, 2019 at 10:26:54AM +0100, Jan Kara wrote: > >>>>>>>> On Wed 02-01-19 20:55:33, Jerome Glisse wrote: > >>>>>>>>> On Wed, Dec 19, 2018 at 12:08:56PM +0100, Jan Kara wrote: > >>>>>>>>>> On Tue 18-12-18 21:07:24, Jerome Glisse wrote: > >>>>>>>>>>> On Tue, Dec 18, 2018 at 03:29:34PM -0800, John Hubbard wrote: > >>>>> [...] > >>>> > >>>> Hi Jerome, > >>>> > >>>> Looks good, in a conceptual sense. Let me do a brain dump of how I see it, > >>>> in case anyone spots a disastrous conceptual error (such as the lock_page > >>>> point), while I'm putting together the revised patchset. > >>>> > >>>> I've studied this carefully, and I agree that using mapcount in > >>>> this way is viable, *as long* as we use a lock (or a construct that looks just > >>>> like one: your "memory barrier, check, retry" is really just a lock) in > >>>> order to hold off gup() while page_mkclean() is in progress. In other words, > >>>> nothing that increments mapcount may proceed while page_mkclean() is running. > >>> > >>> No, increment to page->_mapcount are fine while page_mkclean() is running. > >>> The above solution do work no matter what happens thanks to the memory > >>> barrier. By clearing the pin flag first and reading the page->_mapcount > >>> after (and doing the reverse in GUP) we know that a racing GUP will either > >>> have its pin page clear but the incremented mapcount taken into account by > >>> page_mkclean() or page_mkclean() will miss the incremented mapcount but > >>> it will also no clear the pin flag set concurrently by any GUP. > >>> > >>> Here are all the possible time line: > >>> [T1]: > >>> GUP on CPU0 | page_mkclean() on CPU1 > >>> | > >>> [G2] atomic_inc(&page->mapcount) | > >>> [G3] smp_wmb(); | > >>> [G4] SetPagePin(page); | > >>> ... > >>> | [C1] pined = TestClearPagePin(page); > >> > >> It appears that you're using the "page pin is clear" to indicate that > >> page_mkclean() is running. The problem is, that approach leads to toggling > >> the PagePin flag, and so an observer (other than gup or page_mkclean) will > >> see intervals during which the PagePin flag is clear, when conceptually it > >> should be set. > >> > >> Jan and other FS people, is it definitely the case that we only have to take > >> action (defer, wait, revoke, etc) for gup-pinned pages, in page_mkclean()? > >> Because I recall from earlier experiments that there were several places, not > >> just page_mkclean(). > > > > Yes and it is fine to temporarily have the pin flag unstable. Anything > > that need stable page content will have to lock the page so will have > > to sync against any page_mkclean() and in the end the only thing were > > we want to check the pin flag is when doing write back ie after > > page_mkclean() while the page is still locked. If they are any other > > place that need to check the pin flag then they will need to lock the > > page. But i can not think of any other place right now. > > > > > > OK. Yes, since the clearing and resetting happens under page lock, that will > suffice to synchronize it. That's a good point. > > > [...] > > > >>>> The other idea that you and Dan (and maybe others) pointed out was a debug > >>>> option, which we'll certainly need in order to safely convert all the call > >>>> sites. (Mirror the mappings at a different kernel offset, so that put_page() > >>>> and put_user_page() can verify that the right call was made.) That will be > >>>> a separate patchset, as you recommended. > >>>> > >>>> I'll even go as far as recommending the page lock itself. I realize that this > >>>> adds overhead to gup(), but we *must* hold off page_mkclean(), and I believe > >>>> that this (below) has similar overhead to the notes above--but is *much* easier > >>>> to verify correct. (If the page lock is unacceptable due to being so widely used, > >>>> then I'd recommend using another page bit to do the same thing.) > >>> > >>> Please page lock is pointless and it will not work for GUP fast. The above > >>> scheme do work and is fine. I spend the day again thinking about all memory > >>> ordering and i do not see any issues. > >>> > >> > >> Why is it that page lock cannot be used for gup fast, btw? > > > > Well it can not happen within the preempt disable section. But after > > as a post pass before GUP_fast return and after reenabling preempt then > > it is fine like it would be for regular GUP. But locking page for GUP > > is also likely to slow down some workload (with direct-IO). > > > > Right, and so to crux of the matter: taking an uncontended page lock involves > pretty much the same set of operations that your approach does. (If gup ends up > contended with the page lock for other reasons than these paths, that seems > surprising.) I'd expect very similar performance. > > But the page lock approach leads to really dramatically simpler code (and code > reviews, let's not forget). Any objection to my going that direction, and keeping > this idea as a Plan B? I think the next step will be, once again, to gather some > performance metrics, so maybe that will help us decide. They are already work load that suffer from the page lock so adding more code that need it will only worsen those situations. I guess i will do a patchset with my solution as it is definitly lighter weight that having to take the page lock. Cheers, Jérôme
