Re: [PATCH] mm/slub.c: freelist is ensured to be NULL when new_slab() fails

[Pekka Enberg <penberg@xxxxxx>]

On 29/12/2018 8.25, Peng Wang wrote:
> new_slab_objects() will return immediately if freelist is not NULL.
>
>           if (freelist)
>                   return freelist;
>
> One more assignment operation could be avoided.
>
> Signed-off-by: Peng Wang <rocking@xxxxxxxxxx>

Reviewed-by: Pekka Enberg <penberg@xxxxxxxxxx>

> ---
>   mm/slub.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 36c0befeebd8..cf2ef4ababff 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -2463,8 +2463,7 @@ static inline void *new_slab_objects(struct kmem_cache *s, gfp_t flags,
>   		stat(s, ALLOC_SLAB);
>   		c->page = page;
>   		*pc = c;
> -	} else
> -		freelist = NULL;
> +	}
>   
>   	return freelist;
>   }