On Thu, Mar 31, 2011 at 08:58:03AM -0700, Dave Hansen wrote:
> On Thu, 2011-03-31 at 15:16 +0200, Marek Szyprowski wrote:
> >
> > +unsigned long alloc_contig_freed_pages(unsigned long start, unsigned long end,
> > + gfp_t flag)
> > +{
> > + unsigned long pfn = start, count;
> > + struct page *page;
> > + struct zone *zone;
> > + int order;
> > +
> > + VM_BUG_ON(!pfn_valid(start));
>
> This seems kinda mean. Could we return an error? I understand that
> this is largely going to be an early-boot thing, but surely trying to
> punt on crappy input beats a full-on BUG().
>
> if (!pfn_valid(start))
> return -1;
But still keep the warning?
if (WARN_ON(!pfn_valid(start))
return -1;
-- Steve
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>