> On Dec 21, 2018, at 9:33 AM, Michal Hocko <mhocko@xxxxxxxxxx> wrote: > > On Fri 21-12-18 14:49:38, Burt Holzman wrote: >> Hi, >> >> This patch: 29ef680ae7c21110af8e6416d84d8a72fc147b14 >> [PATCH] memcg, oom: move out_of_memory back to the charge path >> >> has broken the eventfd notification for cgroups-v1. This is because >> mem_cgroup_oom_notify() is called only in mem_cgroup_oom_synchronize and >> not with the new, additional call to mem_cgroup_out_of_memory in the >> charge path. > > Yes, you are right and this is a clear regression. Does the following > patch fixes the issue for you? I am not super happy about the code > duplication but I wasn't able to separate this out from > mem_cgroup_oom_synchronize because that one has to handle the oom_killer > disabled case which is not the case in the charge path because we simply > back off and hand over to mem_cgroup_oom_synchronize in that case. Hi Michal, Thanks for the quick response & patch. I can confirm that with this patch the notification is working for my sample test case. - B
