On Wed 19-12-18 04:46:56, Wei Yang wrote: [...] > Since drain_all_pages() is zone based, by reduce times of > drain_all_pages() also reduce some contention on this particular zone. I forgot to add. As said before this is a really weak justification. If there is really some contention then I would like to see some numbers backing that claim. A proper justification would be that reallying on draining in callers just sucks. As we can see we are doing that suboptimally based on a weak understanding of the functionality. So it makes sense to remove that draining and rely on the isolation code do the right thing. Then it is a clear cleanup. -- Michal Hocko SUSE Labs
