tree: git://git.cmpxchg.org/linux-mmotm.git master
head: 6d5b029d523e959579667282e713106a29c193d2
commit: dc946e7f683be2016c12d8d75e6dd3a28a0d3adb [291/302] fs/: remove caller signal_pending branch predictions
config: x86_64-rhel-7.2-clear (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout dc946e7f683be2016c12d8d75e6dd3a28a0d3adb
# save the attached .config to linux build tree
make ARCH=x86_64
Note: the mmotm/master HEAD 6d5b029d523e959579667282e713106a29c193d2 builds fine.
It only hurts bisectibility.
All error/warnings (new ones prefixed by >>):
fs/buffer.c: In function 'cont_expand_zero':
>> fs/buffer.c:2400:37: error: expected statement before ')' token
if (fatal_signal_pending(current))) {
^
>> fs/buffer.c:2400:3: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if (fatal_signal_pending(current))) {
^~
fs/buffer.c:2400:39: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
if (fatal_signal_pending(current))) {
^
vim +2400 fs/buffer.c
2362
2363 static int cont_expand_zero(struct file *file, struct address_space *mapping,
2364 loff_t pos, loff_t *bytes)
2365 {
2366 struct inode *inode = mapping->host;
2367 unsigned int blocksize = i_blocksize(inode);
2368 struct page *page;
2369 void *fsdata;
2370 pgoff_t index, curidx;
2371 loff_t curpos;
2372 unsigned zerofrom, offset, len;
2373 int err = 0;
2374
2375 index = pos >> PAGE_SHIFT;
2376 offset = pos & ~PAGE_MASK;
2377
2378 while (index > (curidx = (curpos = *bytes)>>PAGE_SHIFT)) {
2379 zerofrom = curpos & ~PAGE_MASK;
2380 if (zerofrom & (blocksize-1)) {
2381 *bytes |= (blocksize-1);
2382 (*bytes)++;
2383 }
2384 len = PAGE_SIZE - zerofrom;
2385
2386 err = pagecache_write_begin(file, mapping, curpos, len, 0,
2387 &page, &fsdata);
2388 if (err)
2389 goto out;
2390 zero_user(page, zerofrom, len);
2391 err = pagecache_write_end(file, mapping, curpos, len, len,
2392 page, fsdata);
2393 if (err < 0)
2394 goto out;
2395 BUG_ON(err != len);
2396 err = 0;
2397
2398 balance_dirty_pages_ratelimited(mapping);
2399
> 2400 if (fatal_signal_pending(current))) {
2401 err = -EINTR;
2402 goto out;
2403 }
2404 }
2405
2406 /* page covers the boundary, find the boundary offset */
2407 if (index == curidx) {
2408 zerofrom = curpos & ~PAGE_MASK;
2409 /* if we will expand the thing last block will be filled */
2410 if (offset <= zerofrom) {
2411 goto out;
2412 }
2413 if (zerofrom & (blocksize-1)) {
2414 *bytes |= (blocksize-1);
2415 (*bytes)++;
2416 }
2417 len = offset - zerofrom;
2418
2419 err = pagecache_write_begin(file, mapping, curpos, len, 0,
2420 &page, &fsdata);
2421 if (err)
2422 goto out;
2423 zero_user(page, zerofrom, len);
2424 err = pagecache_write_end(file, mapping, curpos, len, len,
2425 page, fsdata);
2426 if (err < 0)
2427 goto out;
2428 BUG_ON(err != len);
2429 err = 0;
2430 }
2431 out:
2432 return err;
2433 }
2434
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
