Re: [PATCH] mm: fix setup_zone_pageset section mismatch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 30 Mar 2011 15:47:30 -0700
Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:

> ...
>
> > 
> > I already merged Paul Mundt's patch whcih marks build_all_zonelists()
> > as __ref.  That seems a better solution?
> 
> Merged where?  mmotm?

mm.  

--- a/mm/page_alloc.c~mm-page_allocc-silence-build_all_zonelists-section-mismatch
+++ a/mm/page_alloc.c
@@ -3170,7 +3170,7 @@ static __init_refok int __build_all_zone
  * Called with zonelists_mutex held always
  * unless system_state == SYSTEM_BOOTING.
  */
-void build_all_zonelists(void *data)
+void __ref build_all_zonelists(void *data)
 {
 	set_zonelist_order();
 
_


>
> ...
> 
> > If we'd handled the section via
> > 
> > #ifdef CONFIG_MEMORY_HOTPLUG
> > #define __meminit
> > #else
> > #define __meminit __init
> > #endif
> > 
> > of similar then that would fix things.  iirc we used to do it that
> > way...
> 
> Yes, that older way made more sense to me.

I guess it was too simple.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]