Re: [PATCH V3 updated] arch/powerpc/mm/hugetlb: NestMMU workaround for hugetlb mprotect RW upgrade

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Aneesh,

I love your patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on v4.20-rc5 next-20181207]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Aneesh-Kumar-K-V/arch-powerpc-mm-hugetlb-NestMMU-workaround-for-hugetlb-mprotect-RW-upgrade/20181207-025514
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-allmodconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=powerpc 

All errors (new ones prefixed by >>):

   arch/powerpc/mm/hugetlbpage-radix.c: In function 'radix__huge_ptep_modify_prot_commit':
>> arch/powerpc/mm/hugetlbpage-radix.c:104:6: error: implicit declaration of function 'is_pte_rw_upgrade' [-Werror=implicit-function-declaration]
     if (is_pte_rw_upgrade(pte_val(old_pte), pte_val(pte)) &&
         ^~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/is_pte_rw_upgrade +104 arch/powerpc/mm/hugetlbpage-radix.c

    93	
    94	void radix__huge_ptep_modify_prot_commit(struct vm_area_struct *vma,
    95						 unsigned long addr, pte_t *ptep,
    96						 pte_t old_pte, pte_t pte)
    97	{
    98		struct mm_struct *mm = vma->vm_mm;
    99	
   100		/*
   101		 * To avoid NMMU hang while relaxing access we need to flush the tlb before
   102		 * we set the new value.
   103		 */
 > 104		if (is_pte_rw_upgrade(pte_val(old_pte), pte_val(pte)) &&

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux