> > Currently, memory cgroup don't restrict number of page fault. And we already have > > this feature by CONFIG_CGROUP_PERF if my understanding is correct. Why don't you > > use perf cgroup? > > > > In the other words, after your patch, we have four pagefault counter. Do we > > really need *four*? Can't we consolidate them? > > > > 1. tsk->maj_flt > > 2. perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MAJ) > > 3. count_vm_event(PGMAJFAULT); > > 4. mem_cgroup_count_vm_event(PGMAJFAULT); > > The first three are per-process and per-system level counters. What I > did in this patch is to add per-memcg counters for pgfault and > pgmajfault. This purpose is not to do any limiting but monitoring. I > am not sure about the CONFIG_CGROUP_PERF, does it require > CONFIG_PERF_EVENTS? Yes, per-process counter can be enhanced per-cgroup counter naturally and easily. I guess it's a background idea of that. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>