On Wed, 28 Nov 2018, Kirill A. Shutemov wrote: > On Tue, Nov 27, 2018 at 12:23:32PM -0800, Hugh Dickins wrote: > > > Actually, I think we could VM_BUG_ON(page_mapping(page) != mapping), > > couldn't we? Not that I propose to make such a change at this stage. > > Yeah it should be safe. We may put WARN there. Later yes, but for now I'm leaving the patch unchanged - been burnt before by last minute changes that didn't turn out so well! > Agreed on all fronts. Sorry for the noise. No problem at all: it's important that you challenge what looked wrong. This time around, I was the one with the advantage of recent familiarity. > > > > The rest of the patch *looks* okay, but I found it hard to follow. > > > Splitting it up would make it easier. > > > > It needs some time, I admit: thanks a lot for persisting with it. > > And thanks (to you and to Matthew) for the speedy Acks elsewhere. > > > > Hugh > > -- > Kirill A. Shutemov Thanks again, Hugh
