On 23.11.18 13:54, Michal Hocko wrote: > On Fri 23-11-18 13:37:40, David Hildenbrand wrote: >> User space should always be in charge of how to online memory and >> if memory should be onlined automatically in the kernel. Let's drop the >> parameter to overwrite this - XEN passes memhp_auto_online, just like >> add_memory(), so we can directly use that instead internally. > > Heh, I wanted to get rid of memhp_auto_online so much and now we have it > in the core memory_hotplug. Not a win on my side I would say :/ That is actually a good point: Can we remove memhp_auto_online or is it already some sort of kernel ABI? (as it is exported via /sys/devices/system/memory/auto_online_blocks) > On the other hand this can be seen as a cleanup because it removes that > ambiguity that some callers might be unaware of the memhp_auto_online > leading to a different behavior. I would say this patch is a step into the right direction - remove the flag from the interfaces, then drop it (eventually, as stated not sure if that train has left the station). > >> Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> >> Cc: Juergen Gross <jgross@xxxxxxxx> >> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx> >> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> >> Cc: Dan Williams <dan.j.williams@xxxxxxxxx> >> Cc: Oscar Salvador <osalvador@xxxxxxx> >> Cc: Pavel Tatashin <pasha.tatashin@xxxxxxxxxx> >> Cc: Michal Hocko <mhocko@xxxxxxxx> >> Cc: David Hildenbrand <david@xxxxxxxxxx> >> Cc: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx> >> Cc: Arun KS <arunks@xxxxxxxxxxxxxx> >> Cc: Mathieu Malaterre <malat@xxxxxxxxxx> >> Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> >> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx> > > Acked-by: Michal Hocko <mhocko@xxxxxxxx> > -- Thanks, David / dhildenb
