On Tue 20-11-18 21:51:39, William Kucharski wrote: > > > > On Nov 20, 2018, at 7:12 AM, Michal Hocko <mhocko@xxxxxxxxxx> wrote: > > > > + /* > > + * Check the locked pages before taking a reference to not > > + * go in the way of migration. > > + */ > > Could you make this a tiny bit more explanative, something like: > > + /* > + * Check for a locked page first, as a speculative > + * reference may adversely influence page migration. > + */ sure > > Reviewed-by: William Kucharski <william.kucharski@xxxxxxxxxx> Thanks! -- Michal Hocko SUSE Labs