On 20.11.18 15:25, Michal Hocko wrote: > On Tue 20-11-18 15:18:41, David Hildenbrand wrote: > [...] >> (we could also check for pending signals inside that function if really >> required) > > do_migrate_pages is not the proper layer to check signals. Because the > loop only isolates pages and that is not expensive. The most expensive > part is deeper down in the migration core. We wait for page lock or > writeback and that can take a long. None of that is killable wait which > is a larger surgery but something that we should consider should there > be any need to address this. Indeed, that makes sense. > >> Reviewed-by: David Hildenbrand <david@xxxxxxxxxx> > > Thanks! > -- Thanks, David / dhildenb