Re: [PATCH V10 08/19] btrfs: move bio_pages_all() to btrfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Omar Sandoval <osandov@xxxxxxxxxxx>
Subject: Re: [PATCH V10 08/19] btrfs: move bio_pages_all() to btrfs
From: Ming Lei <ming.lei@xxxxxxxxxx>
Date: Mon, 19 Nov 2018 16:15:09 +0800
Cc: Jens Axboe <axboe@xxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Dave Chinner <dchinner@xxxxxxxxxx>, Kent Overstreet <kent.overstreet@xxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, dm-devel@xxxxxxxxxx, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, Shaohua Li <shli@xxxxxxxxxx>, linux-raid@xxxxxxxxxxxxxxx, linux-erofs@xxxxxxxxxxxxxxxx, David Sterba <dsterba@xxxxxxxx>, linux-btrfs@xxxxxxxxxxxxxxx, "Darrick J . Wong" <darrick.wong@xxxxxxxxxx>, linux-xfs@xxxxxxxxxxxxxxx, Gao Xiang <gaoxiang25@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, Coly Li <colyli@xxxxxxx>, linux-bcache@xxxxxxxxxxxxxxx, Boaz Harrosh <ooo@xxxxxxxxxxxxxxx>, Bob Peterson <rpeterso@xxxxxxxxxx>, cluster-devel@xxxxxxxxxx
In-reply-to: <20181116002356.GC23828@vader>
References: <20181115085306.9910-1-ming.lei@redhat.com> <20181115085306.9910-9-ming.lei@redhat.com> <20181116002356.GC23828@vader>
User-agent: Mutt/1.9.1 (2017-09-22)

On Thu, Nov 15, 2018 at 04:23:56PM -0800, Omar Sandoval wrote:
> On Thu, Nov 15, 2018 at 04:52:55PM +0800, Ming Lei wrote:
> > BTRFS is the only user of this helper, so move this helper into
> > BTRFS, and implement it via bio_for_each_segment_all(), since
> > bio->bi_vcnt may not equal to number of pages after multipage bvec
> > is enabled.
> 
> Shouldn't you also get rid of bio_pages_all() in this patch?

Good catch!

thanks,
Ming

References:
- [PATCH V10 00/19] block: support multi-page bvec
  - From: Ming Lei
- [PATCH V10 08/19] btrfs: move bio_pages_all() to btrfs
  - From: Ming Lei
- Re: [PATCH V10 08/19] btrfs: move bio_pages_all() to btrfs
  - From: Omar Sandoval

Prev by Date: Re: [PATCH V10 07/19] btrfs: use bvec_last_segment to get bio's last page
Next by Date: Re: [PATCH V10 08/19] btrfs: move bio_pages_all() to btrfs
Previous by thread: Re: [PATCH V10 08/19] btrfs: move bio_pages_all() to btrfs
Next by thread: Re: [PATCH V10 08/19] btrfs: move bio_pages_all() to btrfs
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]