Re: [PATCH V10 04/19] block: use bio_for_each_bvec() to map sg

To: Ming Lei <ming.lei@xxxxxxxxxx>
Subject: Re: [PATCH V10 04/19] block: use bio_for_each_bvec() to map sg
From: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 16 Nov 2018 14:33:14 +0100
Cc: Jens Axboe <axboe@xxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Dave Chinner <dchinner@xxxxxxxxxx>, Kent Overstreet <kent.overstreet@xxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, dm-devel@xxxxxxxxxx, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, Shaohua Li <shli@xxxxxxxxxx>, linux-raid@xxxxxxxxxxxxxxx, linux-erofs@xxxxxxxxxxxxxxxx, David Sterba <dsterba@xxxxxxxx>, linux-btrfs@xxxxxxxxxxxxxxx, "Darrick J . Wong" <darrick.wong@xxxxxxxxxx>, linux-xfs@xxxxxxxxxxxxxxx, Gao Xiang <gaoxiang25@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, Coly Li <colyli@xxxxxxx>, linux-bcache@xxxxxxxxxxxxxxx, Boaz Harrosh <ooo@xxxxxxxxxxxxxxx>, Bob Peterson <rpeterso@xxxxxxxxxx>, cluster-devel@xxxxxxxxxx
In-reply-to: <20181115085306.9910-5-ming.lei@redhat.com>
References: <20181115085306.9910-1-ming.lei@redhat.com> <20181115085306.9910-5-ming.lei@redhat.com>
User-agent: Mutt/1.5.17 (2007-11-01)

> +	if (!*sg)
> +		return sglist;
> +	else {

No need for an else after an early return.

Follow-Ups:
- Re: [PATCH V10 04/19] block: use bio_for_each_bvec() to map sg
  - From: Ming Lei

References:
- [PATCH V10 00/19] block: support multi-page bvec
  - From: Ming Lei
- [PATCH V10 04/19] block: use bio_for_each_bvec() to map sg
  - From: Ming Lei