* Pekka Enberg <penberg@xxxxxxxxxx> wrote: > On Thu, Mar 24, 2011 at 9:22 PM, Ingo Molnar <mingo@xxxxxxx> wrote: > > > > * Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote: > > > >> On Thu, 24 Mar 2011, Ingo Molnar wrote: > >> > RIP: 0010:[<ffffffff810570a9>] [<ffffffff810570a9>] get_next_timer_interrupt+0x119/0x260 > >> > >> That's a typical timer crash, but you were unable to debug it with > >> debugobjects because commit d3f661d6 broke those. > >> > >> Christoph, debugobjects do not need to run with interupts > >> disabled. And just because they were in that section to keep all the > >> debug stuff together does not make an excuse for not looking at the > >> code and just slopping it into some totally unrelated ifdef along with > >> a completely bogus comment. > >> > >> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > >> --- > >> mm/slub.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> Index: linux-2.6/mm/slub.c > >> =================================================================== > >> --- linux-2.6.orig/mm/slub.c > >> +++ linux-2.6/mm/slub.c > >> @@ -849,11 +849,11 @@ static inline void slab_free_hook(struct > >> local_irq_save(flags); > >> kmemcheck_slab_free(s, x, s->objsize); > >> debug_check_no_locks_freed(x, s->objsize); > >> - if (!(s->flags & SLAB_DEBUG_OBJECTS)) > >> - debug_check_no_obj_freed(x, s->objsize); > >> local_irq_restore(flags); > >> } > >> #endif > >> + if (!(s->flags & SLAB_DEBUG_OBJECTS)) > >> + debug_check_no_obj_freed(x, s->objsize); > > > > Thanks, this did the trick! > > > > Tested-by: Ingo Molnar <mingo@xxxxxxx> > > > > With this fix i got the warning below - pinpointing a net/bluetooth/hci_core.c > > timer bug. > > Applied, thanks! Just an update: all SLAB/SLUB problems appear to be fixed with the latest patches, so i'm a happy camper! Thanks Pekka, Ingo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>