On Thu, 1 Nov 2018 18:41:33 -0600 William Kucharski <william.kucharski@xxxxxxxxxx> wrote: > > > > On Nov 1, 2018, at 3:47 PM, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > > > > - count = count > PAGE_SIZE ? PAGE_SIZE : count; > > + count = min_t(size_t, count, PAGE_SIZE); > > kbuf = kmalloc(count, GFP_KERNEL); > > if (!kbuf) > > return -ENOMEM; > > Is the use of min_t vs. the C conditional mostly to be more self-documenting? Yup. It saves the reader from having to parse the code to figure out "this is a min operation".