Hi Matthew, On 2018/10/28 18:23, Matthew Wilcox wrote: > On Sun, Oct 28, 2018 at 02:13:26PM +0800, Gao Xiang wrote: >> It's a trivial simplification for get_next_ra_size and >> clear enough for humans to understand. >> >> It also fixes potential overflow if ra->size(< ra_pages) is too large. >> >> Cc: Fengguang Wu <fengguang.wu@xxxxxxxxx> >> Signed-off-by: Gao Xiang <hsiangkao@xxxxxxx> > > Reviewed-by: Matthew Wilcox <willy@xxxxxxxxxxxxx> > > I also considered what would happen with underflow (passing a 'max' > less than 16, or less than 2) and it would seem to do the right thing > in that case. Yeah, thanks for the review ;) I also made a simple tester to test this in order to ensure its correctness and the result shows the same behavior except for the overflowed case. Thanks, Gao Xiang >
