On 2018-09-21 at 21:29 David Hildenbrand <david@xxxxxxxxxx> wrote: > On 21/09/2018 20:17, Dan Williams wrote: > > On Fri, Sep 21, 2018 at 7:24 AM David Hildenbrand <david@xxxxxxxxxx> wrote: > > [..] > >>> Remove the PageReserved flag sounds more reasonable. > >>> And Could we still have a flag to identify it is a device private memory, or > >>> where these pages coming from? > >> > >> We could use a page type for that or what you proposed. (as I said, we > >> might have to change hibernation code to skip the pages once we drop the > >> reserved flag). > > > > I think it would be reasonable to reject all ZONE_DEVICE pages in > > saveable_page(). > > > > Indeed, that sounds like the easiest solution - guess that answer was > too easy for me to figure out :) . > Just to follow-up, is the plan to clear PageReserved for nvdimm pages instead of the approach taken in this patch set? Or should we special case nvdimm/dax pages in kvm_is_reserved_pfn()? Thanks, Barret
